code refactor
related to #8 (closed):
- I kept changes per commit small, so the number of commits got kind of numerous...
Merge request reports
Activity
requested review from @christophknote
assigned to @FObersteiner
@christophknote did you have a look at my comments / suggestions? Should I proceed and work on the TODOs?
Just to put this into context, many of the refactor TODOs are basically nit-picking; the whole package is great I think!
I also started "real" testing, i.e. using the package: writing / reading real data to and from ICARTT format. Some minor things came up, I can post them as issues. My suggestion would be however to complete one round of refactoring first.
cheers, Florian
@FObersteiner I did and thanks very much, great you are getting involved. This week I am on vacation, I will have an in-depth look and merge requests next week! Best, Christoph
-
@christophknote alright, this merge request will be ready when you're back. Have a nice vacation!
added 20 commits
- 8dca7d6e - enumerators: use IntEnum, docstring
- a68241f6 - func sanitize: more meaningful name, use np.isclose for float equality comparison
- 41e1c58f - if [attribute] is None
- 14bd3092 - any and all built-ins take generator expression
- 39c9624d - implicit boolean
- 2c56e1a3 - use f-strings
- 21672649 - datetime object creation from unpacked int generator
- 5d6ab2ec - __str__ and __repr__ for dataset and variable classes (unfinished)
- 136c60b0 - built-in 'vars', readability
- d4557887 - removed try/except from readHeader
- 304a3017 - invalid or unknown format index raises NotImplementedError
- 5c8799d9 - prepared fail test
- 9d301ca8 - readability
- d11f8b99 - removed try/except:pass
- e90a9b8d - more invalid data (invalid line number specifications)
- e1f25ffc - more meaningful name to prnt
- 4ebb5d84 - try/except:pass removed
- c17544f0 - isValidFileName revised and added as a warning
- 4cae8366 - comments
- 201348d9 - more mini-refactorings; explicit for loops, loops over dict keys etc, more TODOs
Toggle commit listmentioned in issue #10 (closed)
added Refactor label
added 1 commit
- 7609e2a1 - updated calculation of number of normal comment lines