From af424cf1c9cd39dc9531ac6a47b6f82f42917ee8 Mon Sep 17 00:00:00 2001
From: Florian Obersteiner <florian.obersteiner@kit.edu>
Date: Tue, 22 Feb 2022 08:56:32 +0100
Subject: [PATCH] two more comments

---
 src/icartt/dataset.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/icartt/dataset.py b/src/icartt/dataset.py
index 86065c4..5741810 100644
--- a/src/icartt/dataset.py
+++ b/src/icartt/dataset.py
@@ -125,7 +125,7 @@ class DataStore2110(collections.UserDict):
         self.add(**newdata)
 
     def addBulkDep(self, ivar, raw):
-        nlines, nvars = raw.shape
+        nlines, nvars = raw.shape # nvars not used
         self._addDeplines(ivar, raw, nlines)
 
     def _addDeplines(self, ivar, raw, n):
@@ -491,6 +491,10 @@ class Dataset:
             self.format = Formats(int(dmp[1]))
         except:
             raise ValueError("ICARTT format {:d} not implemented".format(dmp[1]))
+            # TODO except clause could be re-written like
+            # except ValueError as ve:
+            #     raise ValueError(f"ICARTT format {dmp[1]:d} not implemented") from ve
+            # to show the error trace
 
         if len(dmp) > 2:
             self.version = dmp[2]
-- 
GitLab