From 9d301ca8856723d2ceeea166c863f44c3f9db322 Mon Sep 17 00:00:00 2001
From: Florian Obersteiner <florian.obersteiner@kit.edu>
Date: Wed, 23 Feb 2022 10:34:55 +0100
Subject: [PATCH] readability

---
 src/icartt/dataset.py | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/icartt/dataset.py b/src/icartt/dataset.py
index a0224da..7dbaeaf 100644
--- a/src/icartt/dataset.py
+++ b/src/icartt/dataset.py
@@ -594,8 +594,11 @@ class Dataset:
                 vstandardname += [standardname]
                 vlongname += [longname]
 
-            return { # TODO: refactor dict comp for readability?
-                shortname: Variable(
+            d = {}
+            for shortname, unit, standardname, longname, scale, miss in zip(
+                    vshortname, vunits, vstandardname, vlongname, vscale, vmiss
+                ):
+                d[shortname] = Variable(
                     shortname,
                     unit,
                     standardname,
@@ -604,10 +607,10 @@ class Dataset:
                     miss=miss,
                     vartype=vtype,
                 )
-                for shortname, unit, standardname, longname, scale, miss in zip(
-                    vshortname, vunits, vstandardname, vlongname, vscale, vmiss
-                )
-            }
+
+            return d
+
+
 
         self.dependentVariables = readVars(f, VariableType.DependentVariable)
 
-- 
GitLab