From 304a3017a5f51c32c56144e4ded9e3787419b872 Mon Sep 17 00:00:00 2001
From: Florian Obersteiner <florian.obersteiner@kit.edu>
Date: Wed, 23 Feb 2022 10:30:44 +0100
Subject: [PATCH] invalid or unknown format index raises NotImplementedError

---
 src/icartt/dataset.py | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/icartt/dataset.py b/src/icartt/dataset.py
index 418073d..a0224da 100644
--- a/src/icartt/dataset.py
+++ b/src/icartt/dataset.py
@@ -476,15 +476,10 @@ class Dataset:
 
         nHeaderSuggested = int(dmp[0])
 
-        # TODO: refactor following try/except statement
         try:
             self.format = Formats(int(dmp[1]))
-        except:
-            raise ValueError(f"ICARTT format {int(dmp[1])} not implemented")
-            # TODO except clause could be re-written like
-            # except ValueError as ve:
-            #     raise ValueError(f"ICARTT format {dmp[1]:d} not implemented") from ve
-            # to show the error trace
+        except ValueError as ve:
+            raise NotImplementedError(f"ICARTT format {dmp[1]} not implemented") from ve
 
         if len(dmp) > 2:
             self.version = dmp[2]
-- 
GitLab