From 14bd30923e39edbb8bfcd0aad8decc0199bfca89 Mon Sep 17 00:00:00 2001 From: Florian Obersteiner Date: Wed, 23 Feb 2022 09:07:56 +0100 Subject: [PATCH] any and all built-ins take generator expression --- src/icartt/dataset.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/icartt/dataset.py b/src/icartt/dataset.py index df69787..4d50636 100644 --- a/src/icartt/dataset.py +++ b/src/icartt/dataset.py @@ -163,7 +163,7 @@ class DataStore2110(collections.UserDict): ivarvalue = vmiss_to_npnan(kwargs[self.ivarname], self.missvals[self.ivarname]) # this is an AUX line - if any([x in self.auxvarnames for x in kwargs.keys()]): # TODO: any (all as well) do not require a comprehension; pure generator expression works fine + if any(x in self.auxvarnames for x in kwargs.keys()): # and we create the whole dataset if needed if not ivarvalue in self.data.keys(): self.data[ivarvalue] = { @@ -173,7 +173,7 @@ class DataStore2110(collections.UserDict): self.data[ivarvalue]["AUX"].add(**kwargs) # this is a DEP line - if any([x in self.dvarnames for x in kwargs.keys()]): # TODO: see above: remove [ ] + if any(x in self.dvarnames for x in kwargs.keys()): if not self.ibvarname in kwargs.keys(): raise Exception("Need independent (bounded) variable data.") -- GitLab