From 0cb5da37e7224ffe4663d9cfb1ac4057890680e7 Mon Sep 17 00:00:00 2001
From: Florian Obersteiner <florian.obersteiner@kit.edu>
Date: Thu, 7 Apr 2022 14:31:22 +0200
Subject: [PATCH] added test for revision parser

---
 tests/test_1001.py   | 1 -
 tests/test_bulkIO.py | 7 +++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/test_1001.py b/tests/test_1001.py
index 7a19fcb..738eb6b 100644
--- a/tests/test_1001.py
+++ b/tests/test_1001.py
@@ -163,7 +163,6 @@ class Simple1001TestCase(unittest.TestCase):
             ["Use of these data requires PRIOR OK from the PI"],
         )
         self.assertEqual(ict.normalComments.keywords["OTHER_COMMENTS"].data, ["N/A"])
-        # TODO test revision information
 
     def testReadData(self):
         ict = icartt.Dataset(self.fn, loadData=True)
diff --git a/tests/test_bulkIO.py b/tests/test_bulkIO.py
index 9cbc816..3d8ef77 100644
--- a/tests/test_bulkIO.py
+++ b/tests/test_bulkIO.py
@@ -1,8 +1,8 @@
 import unittest
 import pathlib
 import io
+import re
 
-# import pytest
 
 import icartt
 
@@ -44,7 +44,7 @@ fileinfo = {
 }
 
 
-# TODO: dataset -> close file pointer after read ?!
+# TODO? dataset -> close file pointer after read
 
 
 class BulkIOTestCase(unittest.TestCase):
@@ -75,6 +75,9 @@ class BulkIOTestCase(unittest.TestCase):
             with self.subTest(msg=f"Reading data from test file {str(fn)}"):
                 ict = icartt.Dataset(fn, loadData=True)
                 self.assertEqual(type(ict), icartt.Dataset)
+                m = re.search("R([a-zA-Z0-9]).ict", fn.name)
+                if m:
+                    self.assertEqual(m.groups()[0], ict.revision)
 
     def testWriteHeader(self):
         for fn in self.files_ok:
-- 
GitLab